Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy testcab/cors-anywhere #1489

Closed
wants to merge 1 commit into from
Closed

Deploy testcab/cors-anywhere #1489

wants to merge 1 commit into from

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented May 8, 2023

@github-actions
Copy link

github-actions bot commented May 8, 2023

Deployed to https://pr-1489-aepp-base.stg.aepps.com

@davidyuk
Copy link
Member Author

davidyuk commented May 8, 2023

This container is needed for #1490. @mmpetarpeshev can you deploy it somewhere the proper way? (like cors-anywhere.aepps.com) It also may be used by Superhero Wallet in future to retrieve aepps details.

Meanwile this PR needs to remain opened 🙃

@davidyuk davidyuk mentioned this pull request May 13, 2023
@davidyuk davidyuk mentioned this pull request May 14, 2023
@mmpetarpeshev
Copy link
Contributor

mmpetarpeshev commented May 14, 2023

This container is needed for #1490. @mmpetarpeshev can you deploy it somewhere the proper way? (like cors-anywhere.aepps.com) It also may be used by Superhero Wallet in future to retrieve aepps details.

Meanwile this PR needs to remain opened 🙃

@dincho support this service. If he prefers I do it. Will take a look, but let's sync with him first.
The pipelines don't support draft PRs.The GitHub events are important here.
I see only PR sync pipelines, which means something was wrong with the GitHub workflow.
We can sync over chat what and how you did it.

@dincho
Copy link
Member

dincho commented Dec 22, 2023

No. This is wrong in so many cases. I won't deploy a (practically) public proxy to our environments.
All the applications that wants to be listed in base app browser should support CORS configuration, either wildcard but better base app specific.

@dincho dincho closed this Dec 22, 2023
@davidyuk davidyuk deleted the cors-temp-setup branch January 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants