fix: validate Chainlink oracle account in best-price before reading price data#8
Open
millw14 wants to merge 1 commit intoaeyakovenko:masterfrom
Open
fix: validate Chainlink oracle account in best-price before reading price data#8millw14 wants to merge 1 commit intoaeyakovenko:masterfrom
millw14 wants to merge 1 commit intoaeyakovenko:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getChainlinkPrice()reads hardcoded offsets (138, 216) from any account passed as--oraclewithout validating it's actually a Chainlink feed. If a user passes the wrong account, the function reads arbitrary bytes as price data and displays confident-looking but completely wrong bid/ask quotes.Fix
HEvSKofvBgfaexv23kMabbYqxasxU3mQ4ibBMEmJWHny) before readingRangeErrorOne file, ~40 lines. No other changes.
Note
My previous PR for this was rightfully closed. I branched from my fork's master instead of upstream, so it included thousands of unrelated lines. This PR is rebased cleanly on upstream/master. I'm sorry for the noise.