-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for user to set depth limit by adding data-levels="#" #36
Conversation
…the root nav element. * The number of levels caps at maximum of 6 when using h1 (5 when using h2 etc) * The algorithm can only increment one level at a time, but can drop to lowest available level
Erm, I'm sorry, had cloned the repo some time ago and just got to doing the same thing as you did before seeing this PR, I just opened #37 :( |
@MathieuDuponchelle no problem, your css was way better than mine, though I have the bonus of unit tests and bounds checking the depth. I stole your css but fixed the minor issue of the text shifting 1 pixel when hovering. I also changed the font % since at 6 levels it was making the text very small. |
@kudaba , the text shifting was actually intentional :) As for the size percentage, I must say I didn't test beyond 4 levels, not sure whether anything beyond that will often be used :) Curious, how does your PR handle:
? |
As for bounds checking, can you explain the problem with my PR ? afaict ther's no issue with specifying a too large depth, t's just useless ? |
|
@kudaba , then I would advise using my PR, at least as the base, it does handle any sort of level jumps, which was mandatory for me. |
I gave it a try and there's two issues I ran into:
|
fixed
Fixed as well, good catch, I was wondering what was bugging me when testing it |
Instead of this change I made a pull request to your branch with a few small fixes and my unit tests. closing this one and will go with yours instead since the base implementation is simpler and more robust. |
Fix for #27.
Note: I'm not sure if there's a better way to do the css than just copy pasting up to 6 levels of depth.
Add ability for user to set depth limit by adding data-levels="#" to the root nav element.