Fix the --enable-filters option #347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter objects must be initialized with the options found in the config file but, in the case of `--enable-filters`, new objects were being initialized with config options ignored. This change makes use of the `configured_filter_chain` list of already-initialized filter objects and trims it down by comparing filter class names with the values passed in the command line for `--enable-filters`. Closes: afewmail#40
drebs
force-pushed
the
fix-enable-filters
branch
from
ee930db to
841b78e
Compare
|
Hey @drebs , My feeling is if you command override some option you expect it to ignore the config file, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter objects must be initialized with the options found in the config file but, in the case of
--enable-filters, objects were being re-initialized and config options ignored.This change makes use of the
configured_filter_chainlist of already-initialized filter objects and trims it down by comparing filter class names with the values passed in the command line for--enable-filters.Closes: #40