Set MSRV to 1.85 and test it in CI #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.85 is the Rust version currently in Debian Trixie and subrandr "happens" (I've been purposefully trying to keep that true) to build with it so let's set our MSRV to that.
Note that the {x86_64,aarch64} Linux tests in CI still use nightly Rust, this is because they also run clippy and it seems 1.85 clippy is in kind of a weird state1.
Footnotes
Contradicts nightly clippy with a lifetime lint (which, upon fixing, will trigger a nightly lint) and has a default
comparison_chain2 lint that has since been moved topedantic. ↩Might make sense to enable that lint anyway. ↩