Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate wl_drm, include GBM #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fooishbar
Copy link
Contributor

No description provided.

Encourage people to use the standard linux-dmabuf extension, since
wl_drm is a private implementation detail of Mesa.
GBM format tokens are redundant aliases of DRM formats, conveying the
exact same meaning with the same names and token values. GBM's ABI
requires they be identical.

Extend the DRM format guide descriptor to also discuss GBM formats,
whilst consistently capitalising DRM.

Also include the two inexplicable special cases of XRGB8888/ARGB8888,
which have duplicate token values.
@afrantzis
Copy link
Owner

afrantzis commented Apr 13, 2018

Hi, thanks for the patches! I have merged the wl_drm deprecation doc patch.

I think GBM format support would be more versatile if we used a separate gbm "family". This will allow us to get just GBM results when needed, e.g., "python3 -m pfg find-compatible VK_FORMAT_R8G8B8A8_UNORM gbm" will be able to return just the matching GBM formats which is not possible with the current proposal.

Since the GBM formats are guaranteed to just change the namespace of the DRM formats, one option would be for the implementation to forward requests (after amending the format string) to the DRM code. For testing, using the drm test file as a starting point + the special cases would be sufficient.

@fooishbar
Copy link
Contributor Author

I think GBM format support would be more versatile if we used a separate gbm "family". This will allow us to get just GBM results when needed, e.g., "python3 -m pfg find-compatible VK_FORMAT_R8G8B8A8_UNORM gbm" will be able to return just the matching GBM formats which is not possible with the current proposal.

Since the GBM formats are guaranteed to just change the namespace of the DRM formats, one option would be for the implementation to forward requests (after amending the format string) to the DRM code. Also, it would be nice to have some tests. Using the drm test file as a starting point + the special cases would be sufficient.

Oh yeah, good points both! I'll revise it and submit a new version. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants