Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/download report #87

Merged
merged 19 commits into from
May 11, 2020
Merged

Feature/download report #87

merged 19 commits into from
May 11, 2020

Conversation

tekleayele
Copy link
Collaborator

@tekleayele tekleayele commented May 3, 2020

Added new Report Center page
Screen Shot 2020-05-10 at 1 15 47 AM
Screen Shot 2020-05-10 at 1 16 23 AM
Screen Shot 2020-05-10 at 1 17 48 AM

gedion
gedion previously approved these changes May 3, 2020
Copy link
Contributor

@gedion gedion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would translation to Ethio languages be valuable?

@gedion gedion mentioned this pull request May 3, 2020
@tekleayele tekleayele requested a review from gedion May 3, 2020 21:44
@rkassa
Copy link
Contributor

rkassa commented May 3, 2020

does it make sense to have individual exports of each medical facility?

@yohane55
Copy link
Contributor

yohane55 commented May 4, 2020

@rkassa you are right, the right approach would be to get all the data in single report.

Copy link
Contributor

@yohane55 yohane55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it to export all data in single report?

@tekleayele
Copy link
Collaborator Author

There wasn't an in initial clear cut requirement on this, so I figured there would be some discussions/feedback's before this PR is merged but making the update to a single bulk report should be super easy, will push an update later tonight.

Thank you all

@tekleayele tekleayele requested a review from yohane55 May 10, 2020 17:19
@helomberhane helomberhane merged commit 1cdcb40 into master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants