AG-12978 Fix normalised stacked area for null (un-)connected cases

ag-grid · Dec 4, 2024 · a2fccf0 · a2fccf0
1 parent adcd1e0
commit a2fccf0
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 2 deletions.
diff --git a/packages/ag-charts-community/src/chart/data/processors.ts b/packages/ag-charts-community/src/chart/data/processors.ts
@@ -211,13 +211,19 @@ function normaliseFnBuilder({ normaliseTo, mode }: { normaliseTo: number; mode:
 }
 
 function normaliseFindExtent(mode: 'sum' | 'range', columns: any[][], valueIndexes: number[], datumIndex: number) {
+    let everyValueIsNaN = true;
     const valuesExtent = [0, 0];
     for (const valueIdx of valueIndexes) {
         const column = columns[valueIdx];
         const value: null | number | (null | number)[] = column[datumIndex];
         if (value == null) continue;
+
         // Note - Array.isArray(new Float64Array) is false, and this type is used for stack accumulators
         const valueExtent = typeof value === 'number' ? value : Math.max(...value.map((v) => v ?? 0));
+
+        if (isNaN(valueExtent)) continue;
+        everyValueIsNaN = false;
+
         const valIdx = valueExtent < 0 ? 0 : 1;
         if (mode === 'sum') {
             valuesExtent[valIdx] += valueExtent;
@@ -228,7 +234,10 @@ function normaliseFindExtent(mode: 'sum' | 'range', columns: any[][], valueIndex
         }
     }
 
-    return Math.max(Math.abs(valuesExtent[0]), valuesExtent[1]);
+    const extent = Math.max(Math.abs(valuesExtent[0]), valuesExtent[1]);
+
+    if (everyValueIsNaN || extent === 0) return NaN;
+    return extent;
 }
 
 export function normaliseGroupTo(

diff --git a/...alised-stacked-area-connected-it-should-render-to-canvas-as-expected-1-snap.png b/...alised-stacked-area-connected-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/...-area-connected-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png b/...-area-connected-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/...e-for-normalised-stacked-area-it-should-render-to-canvas-as-expected-1-snap.png b/...e-for-normalised-stacked-area-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/...ed-stacked-area-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png b/...ed-stacked-area-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/...ised-stacked-area-with-zeroes-it-should-render-to-canvas-as-expected-1-snap.png b/...ised-stacked-area-with-zeroes-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/...rea-with-zeroes-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png b/...rea-with-zeroes-reversed-axes-it-should-render-to-canvas-as-expected-1-snap.png
diff --git a/packages/ag-charts-community/src/chart/series/cartesian/areaSeries.ts b/packages/ag-charts-community/src/chart/series/cartesian/areaSeries.ts
@@ -207,7 +207,7 @@ export class AreaSeries extends CartesianSeries<
         }
 
         const common: Partial<DatumPropertyDefinition<unknown>> = { invalidValue: null };
-        if ((isDefined(normalizedTo) || connectMissingData) && stackCount > 1) {
+        if (connectMissingData && stackCount > 1) {
             common.invalidValue = 0;
         }
         if (!visible) {