lint

ag-grid · Jan 7, 2025 · f900390 · f900390
1 parent 0e74939
commit f900390
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/packages/ag-charts-community/src/chart/axis/axis.ts b/packages/ag-charts-community/src/chart/axis/axis.ts
@@ -474,7 +474,7 @@ export abstract class Axis<
         this.animatable = animatable;
     }
 
-    _scaleNiceDomainRange: number = NaN;
+    _scaleNiceDomainRangeExtent: number = NaN;
     calculateLayout(initialPrimaryTickCount?: number) {
         const { scale, label, visibleRange, nice } = this;
 
@@ -483,15 +483,15 @@ export abstract class Axis<
 
         this.updateScale();
 
-        const range = findRangeExtent(this.range);
+        const rangeExtent = findRangeExtent(this.range);
 
         const domain = this.dataDomain.domain;
         let tickLayoutDomain: D[] | undefined;
         if (visibleRange[0] === 0 && visibleRange[1] === 1) {
             tickLayoutDomain = undefined;
         } else if (!nice) {
             tickLayoutDomain = domain;
-        } else if (this._scaleNiceDomainRange === range) {
+        } else if (this._scaleNiceDomainRangeExtent === rangeExtent) {
             tickLayoutDomain = this.scale.domain;
         } else {
             tickLayoutDomain = this.calculateTickLayout(domain, NiceMode.TickAndDomain, [0, 1]).niceDomain;
@@ -514,7 +514,7 @@ export abstract class Axis<
 
         this.scale.domain = niceDomain;
 
-        this._scaleNiceDomainRange = nice ? range : NaN;
+        this._scaleNiceDomainRangeExtent = nice ? rangeExtent : NaN;
 
         const specifier = label.format;
         this.labelFormatter =

diff --git a/packages/ag-charts-community/src/scale/timeScale.ts b/packages/ag-charts-community/src/scale/timeScale.ts
@@ -111,7 +111,7 @@ function getDefaultDateTicks({
     visibleRange: [number, number];
 }) {
     const t = getTickInterval(start, stop, tickCount, minTickCount, maxTickCount);
-    return t ? t.range(new Date(start), new Date(stop), undefined, visibleRange) : []; // inclusive stop
+    return t ? t.range(new Date(start), new Date(stop), { visibleRange }) : []; // inclusive stop
 }
 
 export function getDateTicksForInterval({
@@ -132,7 +132,7 @@ export function getDateTicksForInterval({
     }
 
     if (interval instanceof TimeInterval) {
-        const ticks = interval.range(new Date(start), new Date(stop), undefined, visibleRange);
+        const ticks = interval.range(new Date(start), new Date(stop), { visibleRange });
         if (isDenseInterval(ticks.length, availableRange)) {
             return;
         }
@@ -148,7 +148,7 @@ export function getDateTicksForInterval({
 
     if (timeInterval) {
         const i = timeInterval.timeInterval.every(absInterval / (timeInterval.duration / timeInterval.step));
-        return i.range(new Date(start), new Date(stop), undefined, visibleRange);
+        return i.range(new Date(start), new Date(stop), { visibleRange });
     }
 
     let date = new Date(start);
@@ -183,7 +183,7 @@ function updateNiceDomainIteration(d0: Date, d1: Date, ticks: ScaleTickParams<Ti
     }
 
     if (i) {
-        const intervalRange = i.range(new Date(start), new Date(stop), true);
+        const intervalRange = i.range(new Date(start), new Date(stop), { extend: true });
         const domain = isReversed ? [...intervalRange].reverse() : intervalRange;
         const n0 = domain[0];
         const n1 = domain.at(-1)!;

diff --git a/packages/ag-charts-community/src/util/time/interval.ts b/packages/ag-charts-community/src/util/time/interval.ts
@@ -53,7 +53,11 @@ export class TimeInterval {
      * @param stop Range end.
      * @param extend If specified, the requested range will be extended to the closest "nice" values.
      */
-    range(start: Date, stop: Date, extend: boolean = false, visibleRange?: [number, number]): Date[] {
+    range(
+        start: Date,
+        stop: Date,
+        { extend = false, visibleRange }: { extend?: boolean; visibleRange?: [number, number] } = {}
+    ): Date[] {
         const rangeCallback = this._rangeCallback?.(start, stop);
 
         const e0 = this._encode(extend ? this.floor(start) : this.ceil(start));

diff --git a/packages/ag-charts-enterprise/src/features/navigator/shapes/rangeMask.ts b/packages/ag-charts-enterprise/src/features/navigator/shapes/rangeMask.ts
@@ -79,7 +79,9 @@ export class RangeMask extends Path {
 
         clippedRoundRect(path, ax, ay, aw, ah, cornerRadiusParams, new BBox(ax, ay, minX - ax, ah));
         clippedRoundRect(path, ax, ay, aw, ah, cornerRadiusParams, new BBox(maxX, ay, aw + ax - maxX, ah));
-        clippedRoundRect(visiblePath, ax, ay, aw, ah, cornerRadiusParams, new BBox(minX, ay, maxX - minX, ah));
+        if (maxX - minX > 1) {
+            clippedRoundRect(visiblePath, ax, ay, aw, ah, cornerRadiusParams, new BBox(minX, ay, maxX - minX, ah));
+        }
     }
 
     protected override renderStroke(ctx: _ModuleSupport.CanvasContext, path?: Path2D): void {