Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-13216 Gauges pickFocus implementation #3324

Merged
merged 9 commits into from
Jan 7, 2025
Merged

Conversation

olegat
Copy link
Contributor

@olegat olegat commented Jan 6, 2025

@olegat olegat marked this pull request as ready for review January 6, 2025 16:27
@olegat olegat requested review from alantreadway and a team as code owners January 6, 2025 16:27
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olegat added 8 commits January 7, 2025 09:31
Also use the same logic as hierarchial charts to repurpose the focus.seriesIndex
value.
We'll add invisible bars (fill: 'rgba(0,0,0,0)') so that it can still be picked
by the RadialGaugeSeries.pickFocus method. Also add an e2e test for all
permutations of bar/needle visibilities.
@olegat olegat force-pushed the AG-13216/gauges_pickFocus branch from e4c75ea to 8a2f814 Compare January 7, 2025 09:34
@olegat olegat merged commit e9bce73 into latest Jan 7, 2025
26 checks passed
@olegat olegat deleted the AG-13216/gauges_pickFocus branch January 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants