AG-13383 Conversion for new modules in packages #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephanemw
approved these changes
Dec 2, 2024
| addNewIdentifierNextToGiven(root, module, AllCommunityModule); | ||
| }); | ||
|
|
||
| return root.toSource(); |
There was a problem hiding this comment.
We don't need to return anything from transformers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
--using-charts=migrate command option to help users configure the transform when we don't know enough just by looking at the import paths.Added transforms for
Outstanding
Decide how to handle
ag-grid-communityusers as we have no clear correct point to add theAllCommunityModulesmodule registration.