Improve deriving support for nested types#38
Merged
Conversation
This _does_ support the builtin `Term` datatype, but both generating the instance and evaluating it are incredibly slow, so there is some future work. However, there are some test cases for data types that are supported now that haven't been previously.
Collaborator
Author
|
@omelkonian I don't know your current situation, do you want to still review PRs? |
omelkonian
approved these changes
May 6, 2026
Collaborator
omelkonian
left a comment
omelkonian
left a comment
There was a problem hiding this comment.
LGTM
The performance side of things is really a blocker; hope we figure out a way to make this usable for large records / deeply nested types soon..
Collaborator
Author
|
Yeah, I should be able to continue investigating this some time soon. Thanks for the CI fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does support the builtin
Termdatatype, but both generating the instance and evaluating it are incredibly slow, so there is some future work. However, there are some test cases for data types that are supported now that haven't been previously.