Fix universe level typo in Function.Construct.Constant
#2841
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquescomeaux
changed the title
Function.Construct.Constant
gallais
approved these changes
Oct 23, 2025
jamesmckinna
approved these changes
Oct 25, 2025
| -- Setoid bundles | ||
|
|
||
| module _ (S : Setoid a ℓ₂) (T : Setoid b ℓ₂) where | ||
| module _ (S : Setoid a ℓ₁) (T : Setoid b ℓ₂) where |
There was a problem hiding this comment.
I'm happy with this as well.
The operation is recommended as the replacement for the deprecated Function.Equality.const, which did have a more Level-polymorphic type, so I think that this one should as well.
That said, there do not seem to be any other uses of either operation in stdlib, so it's a bit hard to tell what the client consequences of this might be, but... absent telepathy, not much we can do about that!
|
Thanks @jacquescomeaux for your first PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo preventing
Function.Construct.Constant.functionfrom being as general as possible