Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable submission of repayment requests #486

Open
FestplattenSchnitzel opened this issue Jan 19, 2024 · 1 comment · May be fixed by #465 or agdsn/pycroft#677
Open

Enable submission of repayment requests #486

FestplattenSchnitzel opened this issue Jan 19, 2024 · 1 comment · May be fixed by #465 or agdsn/pycroft#677

Comments

@FestplattenSchnitzel
Copy link
Member

Note: this issue also discusses parts of the design / implementation that concern Pycroft. I currently think that's a good idea in order to keep all the information in one place. Please speak up if you think otherwise.

The submission of repayment requests should be integrated into the membership termination workflow, as that's where most of them occur. Requests after accidental (high) transfers do happen, but a lot less frequent. We can continue to use PDF forms for such cases.

Proposed workflow:

  • Member sets termination date
  • Information / forms are shown based on (projected) remaining balance
    • Balance = 0: Nothing to do
    • Balance < 0: Display payment details to pay outstanding amount
    • Balance > 0: Decide what to do with remaining balance

Proposed options for Balance > 0:

  • Do nothing (useful when doing a term abroad, we need to check compatibility with membership fee regulations)
  • Donate remaining balance
  • Request a repayment for the remaining balance

The chosen option should be saved in Pycroft together with the other information of the scheduled cancellation. In case the scheduled membership cancellation is cancelled later, the data should be deleted. In case the scheduled membership cancellation is not cancelled until the desired date, the chosen action is executed.

  • For the "Do nothing" option this means nothing happens (obviously).
  • For the "Donate remaining balance" option an (unconfirmed?) donation transaction is created.
  • For the "Requests repayment" option the request will now be shown to the treasurers
@LukasGibeh
Copy link
Member

Hi @FestplattenSchnitzel

looks fine from my side. Maybe a few remarks:

  • We should make sure that we are really entitled to take donations, as this was not always clear as far as I remember due to our legal status
  • For the reimbursement option, we should inform our members that the order will not become effective before the end of the membership and will be manually checked by our treasurers so a delay of up to $x weeks can be expected
  • When displaying the remaining balance, we should include the date of the last deposit on the member's account to not accidentally offer the wrong option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants