Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable submission of repayment requests #465

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Enable submission of repayment requests #465

wants to merge 3 commits into from

Conversation

FestplattenSchnitzel
Copy link
Member

@FestplattenSchnitzel FestplattenSchnitzel commented Sep 9, 2023 •
edited by lukasjuhrich
Loading

  • Run the tests and see them pass
  • Rebase your branch on top of develop
  • Include tests for features you introduced / bugs you fixed

Feature TODOs:

  • Integrate into cancellation workflow
  • Add translations for new strings

lukasjuhrich
lukasjuhrich reviewed Sep 22, 2023
View reviewed changes
sipa/forms.py Outdated Show resolved Hide resolved
@FestplattenSchnitzel FestplattenSchnitzel force-pushed the request_repayment branch 2 times, most recently from 4683231 to 5194e89 Compare September 30, 2023 11:40
@lukasjuhrich
Copy link
Collaborator

What's the status of this PR? it somewhat depended on backend work in pycroft, right?

@FestplattenSchnitzel
Copy link
Member Author

Right. But also this needs to be properly integrated into the membership cancellation workflow.

@FestplattenSchnitzel FestplattenSchnitzel linked an issue Jan 19, 2024 that may be closed by this pull request
Enable submission of repayment requests #486
Open
lukasjuhrich
lukasjuhrich reviewed Feb 3, 2024
View reviewed changes
sipa/model/misc.py Outdated Show resolved Hide resolved
@lukasjuhrich
Copy link
Collaborator

@FestplattenSchnitzel FYI I added „translations“ to the top-level TODO-list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasjuhrich lukasjuhrich lukasjuhrich left review comments

Assignees
No one assigned
Labels
None yet
Projects
Software Dev Kanban
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable submission of repayment requests
2 participants
@FestplattenSchnitzel @lukasjuhrich