[#156] Meaningful names for benchmark scenarios#159
Closed
charlesbmi wants to merge 243 commits intomainfrom
Closed
[#156] Meaningful names for benchmark scenarios#159charlesbmi wants to merge 243 commits intomainfrom
charlesbmi wants to merge 243 commits intomainfrom
Conversation
Co-authored-by: Diogo de Lucena <lucenadsl@gmail.com> Co-authored-by: Pedro Sfriso <pedro.sfriso@ae.studio> Co-authored-by: Darin Erat Sleiter <darin@ae.studio>
…y on CI and docker
Removing stride dependency
Releasing to pypi main repo
…file Regenerating poetry lock file
…cy_change Changing scipy dependency of ndk so that it doesn't conflict with stride's dependency
* Pin stride version in all the places we specify pip install * Fix dead link
* various documentation changes and corrections * homer example * Fixing Homer Example added * reversion commit * formatting with lint * formatting with lint * added color scale control to steady state renders * Revert "added color scale control to steady state renders" This reverts commit 13c1ffd. * removed comment * Update docs/examples/plot_homer.py docs update Co-authored-by: charles <charles@ae.studio> * fixed documentation commenting * fixed dead link --------- Co-authored-by: charles <charles@ae.studio>
…ar interpolation (#177) * Add interp dimension in nearest-neighbors interpolation to match * Add test for using nearest-neighbors interpolation for delay-and-sum * Lint code
* Removing gcc as an option to use ndk on mac
NewtonSander
force-pushed
the
156-meaningful-names-for-benchmark-scenarios
branch
from
b888a23 to
c96f396
Compare
NewtonSander
force-pushed
the
156-meaningful-names-for-benchmark-scenarios
branch
from
b864001 to
f4d477e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#156
To avoid generating merge conflicts on a few open PRs, I won't merge this until some of the larger PRs touching
Scenarioare merged.Introduction
The scenario numbering does not correspond to anything meaningful. Instead, it would be helpful for users if we named them with descriptive names, like "3-layer skull model" and "RealisticSkull"
Changes
Rename scenarios:
Scenario0-> ScenarioSimpleScenario1-> ScenarioFlatSkullScenario2-> ScenarioRealisticSkullScenario2Benchmark7-> ScenarioRealisticSkullCroppedScenario3-> ScenarioUltrasoundPhantomBehavior
How the new behavior is different from the current behavior, how you tested and how the reviewer can test it.
All unit/integration tests and docs should run as usual. I also searched the project to check for any variable names I missed.