feat(providers): parse thinking tags in OpenAI compatible models#1496
feat(providers): parse thinking tags in OpenAI compatible models#1496yunxilyf wants to merge 4 commits intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement by enabling the system to parse and extract 'thinking' tags from responses generated by OpenAI compatible models. This allows for a more granular understanding and display of an AI's internal reasoning. Concurrently, the user interface for channel settings has been refined to consistently show filtering options, and the underlying data handling for these settings has been made more robust to prevent type-related issues. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables parsing of <think> tags from OpenAI-compatible model responses and exposes the filtering options for thinking and tool messages on the console channel UI. The changes in the Python backend correctly parse these tags from streaming responses. In the frontend, the logic for handling the filter toggles in console/src/pages/Control/Channels/index.tsx can be simplified by removing the redundant Boolean() constructor, as the logical NOT ! operator is sufficient and more idiomatic. Additionally, a small redundancy was found in the Python code where or "" is used unnecessarily.
Description
[Describe what this PR does and why]
Related Issue: Fixes #(issue_number) or Relates to #(issue_number)
Security Considerations: [If applicable, e.g. channel auth, env/config handling]
Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passespytestor as relevant) and they passTesting
[How to test these changes]
Local Verification Evidence
Additional Notes
[Optional: any other context]