Skip to content

fix(channels): skip empty text blocks in DingTalk rich text parsing #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xieyxclack merged 2 commits into from
Mar 16, 2026
Merged

fix(channels): skip empty text blocks in DingTalk rich text parsing #1554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0d587
fix(channels): skip empty text blocks in DingTalk rich text parsing
mvanhorn Mar 16, 2026
a486f8f
remove tests and reformat code
xieyxclack Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/copaw/app/channels/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ def build_agent_request_from_user_content(

if not content_parts:
content_parts = [
TextContent(type=ContentType.TEXT, text=""),
TextContent(type=ContentType.TEXT, text=" "),
]
msg = Message(
type=MessageType.MESSAGE,
Expand Down
14 changes: 8 additions & 6 deletions src/copaw/app/channels/dingtalk/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,14 @@ def _parse_rich_content(
# Text may be under "text" or "content" (API variation).
item_text = item.get("text") or item.get("content")
if item_text is not None:
content.append(
TextContent(
type=ContentType.TEXT,
text=(item_text or "").strip(),
),
)
stripped = (item_text or "").strip()
if stripped:
content.append(
TextContent(
type=ContentType.TEXT,
text=stripped,
),
)
# Picture items may use pictureDownloadCode or downloadCode.
dl_code = (
item.get("downloadCode")
Expand Down
Loading