feat(console): implement /console/chat endpoint for streaming agent r…#1571
feat(console): implement /console/chat endpoint for streaming agent r…#1571zhijianma merged 6 commits intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the console's chat functionality by implementing a new streaming API endpoint. This change allows for real-time, interactive agent responses in the console, moving away from a traditional request-response model to a more dynamic streaming experience. The update involves both frontend adjustments to consume the new endpoint and backend modifications to handle the streaming logic and session management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new /console/chat endpoint to enable streaming agent responses to the web UI. The changes are well-structured, involving a new streaming endpoint in FastAPI, refactoring the ConsoleChannel to support Server-Sent Events (SSE), and updating the frontend to use this new endpoint. The implementation is generally solid, but I've identified a potential issue in the new endpoint's logic concerning how the channel_id is handled, which could lead to inconsistent behavior. My review includes a specific suggestion to address this for improved robustness and clarity.
…esponses
Description
[Describe what this PR does and why]
Related Issue: Fixes #(issue_number) or Relates to #(issue_number)
Security Considerations: [If applicable, e.g. channel auth, env/config handling]
Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passespytestor as relevant) and they passTesting
[How to test these changes]
Local Verification Evidence
Additional Notes
[Optional: any other context]