fix(install): allow modification of preset values on upgrade#558
Open
nillikechatchat wants to merge 2 commits intoagentscope-ai:mainfrom
Open
fix(install): allow modification of preset values on upgrade#558nillikechatchat wants to merge 2 commits intoagentscope-ai:mainfrom
nillikechatchat wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
In step_admin(), step_network(), step_volume(), and step_workspace(), when variables were already set (e.g., loaded from existing config), the code would skip the prompt and only print a 'preset' message, preventing users from modifying these values. This fix removes the else branches that were skipping prompts, and always calls prompt_optional() or adds upgrade-aware prompt handling which correctly handles both new installations and upgrade scenarios with proper 'back' navigation support. Co-authored-by: nillikechatchat <yuanhenglizhen2050@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, several step_* functions would skip prompts when values were already set during upgrade scenarios. This prevented users from modifying settings by pressing 'b' to go back and re-enter values.
Fixed Functions
step_admin()HICLAW_ADMIN_PASSWORDstep_network()HICLAW_LOCAL_ONLYstep_volume()HICLAW_DATA_DIRstep_workspace()HICLAW_WORKSPACE_DIRAdded i18n Messages
port.local_only.title_short(网络访问模式 / Network Access Mode)port.local_only.val_local(仅本机 / Local only)port.local_only.val_external(允许外部访问 / External access)data.title_short(数据持久化 / Data Persistence)workspace.title_short(Manager 工作空间 / Manager Workspace)Test Plan
./install/hiclaw-install.shwith existing configuration (upgrade mode)Related
This fix follows the pattern established by
step_runtime(),step_e2ee(),step_docker_proxy(), andstep_idle()which already handle upgrade scenarios properly.