Skip to content

Fix: skip trainer config validation in bench mode #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-x-c merged 1 commit into from
May 9, 2026
+1 −1
Merged

Fix: skip trainer config validation in bench mode #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trinity/common/config_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ def validate(self, config: Config) -> None:
or save checkpoint strategy is invalid.
"""
if (
config.mode not in ["train", "both", "bench", "colocate"]
config.mode not in ["train", "both", "colocate"]
and config.trainer.trainer_strategy != "megatron"
):
return
Expand Down
Loading