fix: old version ray placement will set the available GPUs to 0 for vllm#112
Merged
fix: old version ray placement will set the available GPUs to 0 for vllm#112
Conversation
Collaborator
linqinluli
commented
May 8, 2026
- bug fix for TP>1 in sampling backend. When tensor_parallel_size > 1, vLLM spawns an EngineCore in a background process that inherits CUDA_VISIBLE_DEVICES from the parent Ray actor. Previously, num_gpus=0 caused Ray to set CUDA_VISIBLE_DEVICES="", so the child process saw zero GPUs and vLLM crashed with KeyError: 'bundles'. By assigning num_gpus=tensor_parallel_size, Ray populates CUDA_VISIBLE_DEVICES correctly, and vLLM handles its own internal placement group.
- Some other modifications for pre-commit and gitignore.
vanwaals
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.