Skip to content

Commit

Permalink
Remove decoding of just encoded value
Browse files Browse the repository at this point in the history
  • Loading branch information
@agigleux
agigleux committed Jan 8, 2021
1 parent 1693e31 commit 75b7c5b
Show file tree
Hide file tree
Showing 49 changed files with 137 additions and 97 deletions.
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest00293.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest00303.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest00496.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest00498.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest00567.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01066.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01287.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01363.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01430.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01446.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01533.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01610.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest01940.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ private static String doSomething(HttpServletRequest request, String param) thro

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/cmdi/issueexpected/BenchmarkTest02152.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ private static String doSomething(HttpServletRequest request, String param) thro

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest01241.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest01326.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest01568.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest01831.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ private static String doSomething(HttpServletRequest request, String param) thro

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest02299.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,9 @@ private static String doSomething(HttpServletRequest request, String param) thro

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/org/owasp/benchmark/testcode/ldapi/issueexpected/BenchmarkTest02472.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ private static String doSomething(HttpServletRequest request, String param) thro

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/owasp/benchmark/testcode/pathtraver/issueexpected/BenchmarkTest00362.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down
7 changes: 4 additions & 3 deletions ...iscarded/bad_sink/BenchmarkTest00459.java → ...ver/issueexpected/BenchmarkTest00459.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down Expand Up @@ -51,8 +51,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
7 changes: 4 additions & 3 deletions ...iscarded/bad_sink/BenchmarkTest00627.java → ...ver/issueexpected/BenchmarkTest00627.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down Expand Up @@ -47,8 +47,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
7 changes: 4 additions & 3 deletions ...iscarded/bad_sink/BenchmarkTest00700.java → ...ver/issueexpected/BenchmarkTest00700.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down Expand Up @@ -49,8 +49,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
2 changes: 1 addition & 1 deletion ...iscarded/bad_sink/BenchmarkTest00785.java → ...ver/issueexpected/BenchmarkTest00785.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down
7 changes: 4 additions & 3 deletions ...iscarded/bad_sink/BenchmarkTest00787.java → ...ver/issueexpected/BenchmarkTest00787.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down Expand Up @@ -60,8 +60,9 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}


Expand Down
2 changes: 1 addition & 1 deletion ...iscarded/bad_sink/BenchmarkTest00788.java → ...ver/issueexpected/BenchmarkTest00788.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down
7 changes: 4 additions & 3 deletions ...iscarded/bad_sink/BenchmarkTest01034.java → ...ver/issueexpected/BenchmarkTest01034.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down Expand Up @@ -83,8 +83,9 @@ public String doSomething(HttpServletRequest request, String param) throws Servl

String bar = "";
if (param != null) {
bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
//bar = new String( org.apache.commons.codec.binary.Base64.decodeBase64(
//org.apache.commons.codec.binary.Base64.encodeBase64( param.getBytes() ) ));
bar = new String( param.getBytes() );
}

return bar;
Expand Down
2 changes: 1 addition & 1 deletion ...iscarded/bad_sink/BenchmarkTest01117.java → ...ver/issueexpected/BenchmarkTest01117.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @created 2015
*/

package org.owasp.benchmark.testcode.pathtraver.issueexpected_discarded.bad_sink;
package org.owasp.benchmark.testcode.pathtraver.issueexpected;

import java.io.IOException;

Expand Down
Loading

0 comments on commit 75b7c5b

Please sign in to comment.