Propagate return type of call effect with generic arguments #691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect the result type of a call effect with generic arguments to be propagated.
However, this does not work:
Changing the type of the arguments to
any[]
allows the result type to propagate:The problem comes from the definition of
SagaReturnType
:When
S
is the type of a function whose arguments are a constrained type variable, typescript cannot compareany[]
against the type variables and is unable to decide the conditional types.The following code illustrates this limitation in the type system:
Parameterizing
SagaReturnType
over Args fixes the problem by avoiding the comparison betweenany[]
and a constrained type variable. The following declarations fix the initial wrapped call example above:This pull request copies and adapts the definition of
SagaReturnType
from@redux-saga/core
as outlined above and makes the necessary changes throughout the type definitions.