Skip to content

Commit

Permalink
update to use LTS Node 18
Browse files Browse the repository at this point in the history
- Node 14 [fails to install](https://github.com/agilgur5/react-signature-canvas/actions/runs/12562533381/job/35023139557?pr=112)
  - ```txt
    Run actions/setup-node@v3
    Attempting to download 14.x...
    Not found in manifest. Falling back to download directly from Node
    Error: Unable to find Node version '14.x' for platform darwin and architecture arm64.
    ```

- keep Node 16 for now, although it is out-of-support
  - ensure continuous range testing; should bump that later too
  • Loading branch information
agilgur5 committed Dec 31, 2024
1 parent cb09cf7 commit f815767
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
# TODO: add back Node 18 once node-canvas is properly supported: https://github.com/Automattic/node-canvas/issues/2025
node-version: [14.x, 16.x] # LTS Node: https://nodejs.org/en/about/releases/
node-version: [16.x, 18.x] # LTS Node: https://nodejs.org/en/about/releases/
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
Expand Down

0 comments on commit f815767

Please sign in to comment.