-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make xmpp-client into a library #113
Open
massar
wants to merge
28
commits into
agl:master
Choose a base branch
from
tridentli:library
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate MUC support
We'll move the XIO out into xlib/xio.go next
* Move Input.AddUser + lock/uids/uidComplete/lastTarget to Session where it belongs * Add functions to Session to give access to these * Split mainloop into two parts (Session and UI) * Many many small changes to get things compiling again ;) but it still works after all this :)
…t dails benefits from it
… to be done in a xmpplib client, rest is callback
Librarize xmpp-client
… a channel in the XIO implementation
…r messages and not just the channel's jid
Repo moved to https://github.com/secludedsoc/xmpp-go/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect, but it is a IMHO reasonable split to get most of the code out of the way into xlib so that ui.go/input.go actually do what they need to do while xlib handles session management etc.