Allow more then on runStep container#355
Open
kvaster wants to merge 2 commits intoagola-io:masterfrom
Open
Conversation
Author
|
Any chances to discuss PR ? |
Member
|
@kvaster I took a look at the PR but there're many changes I can't follow. Before the code changes I'd like to understand and discuss the use case/cases you're proposing and then understand how these should be expressed in the config specification and then implement them. Can you open a new issue to discuss this? |
Author
|
I've created issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently agola can run command only in one container - the first one. Other containers are always treated as 'service container'. This is not comfortable even for clone operation - git binary may be absent in 'build' container.
This PR allow containers to have names and allow to specify container for runStep. First container and named containers are always treated as 'non-service'. If no container is specified for clone step then 'clone' container will be used. 'clone' container will default to alpine-git if unspecified.
Example: