Skip to content

Conversation

@desislavva
Copy link

Motivation and context

The confirmTransactions (Keplr) function does not work correctly when attempting to confirm a transaction that executes an execMsg to a contract. This branch is my view of what the problem is and how it works for me.

Versions

  • "@agoric/synpress" - v3.8.1 (Latest)
  • Keplr - Default version (not using KEPLR_VERSION)

Current behavior

The "Details" button is clicked.

Expected behavior

The "Approve" button is clicked.

Other useful info

Based on my observations, the issue occurs because additional information appears on the confirmation page in these cases, accompanied by an extra button "Details" (have a look at the pictures). However, the current implementation assumes that there is only one button on this page: https://github.com/agoric-labs/synpress/blob/dev/pages/keplr/notification-page.js#L1. That's why the first 'button' is pressed.

keplr1
keplr2

Quality checklist

  • [ x] I have performed a self-review of my code.
  • [ ] If it is a core feature, I have added thorough e2e tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant