Make alert function advisable + fix advice lib #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small inconsistency in the advice
defadvice
macro + makes the modal function advisable. Includes updates to the tests to catch issues like this in the future.Fixes #74
Closes #75
Closes #95
Then you can add the following to your config.fnl:
Then the spacehammer modal will display on all screens. @Grazfather may create a follow up PR to add it to the docs as an official, practical example.
The exact cause was due to use the metatables to make the advisable functions callable while storing references to their advice entry and key.