Feat/refactor css custom props and spelling #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add colors for main one and others in `root` as `CSS variables` or `CSS custom properties`. We also added these variables in light mode and dark one for user prefer color scheme.
Update all `color` and `background-color` properties with `CSS variables` or `CSS custom properties`.
Add custom properties in CSS selectors and use inner custom properties to reflect with all properties which have vendor prefixes.
|
@krypton225 is attempting to deploy a commit to the ahmed0saber's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello @krypton225 , I have reviewed the great work you have done and we are about to merge it after fixing these small issues. Best wishes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRmakes some changes as following:Enhance all
CSSproperties with usingcustom CSS properties(orCSS variables) to improve flexibility if we need to change any thing easily.Make styles for colors and backgrounds in two prefers color scheme modes:
lightanddarkto make the website more better with user preferences.Enhance some selector to use
logical CSS propertieslike:margin-block-end, … etc to make the website with more flexibility.Update the mistake spelling in the text.
Make font sizes as
CSS custom properties(orCSS variables) to use it in hole website to improve responsive design.Use
local scope CSS custom properties(orCSS variables) in some selectors.