Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <link> and <script> for Klipse CSS loading (related to #42) #43

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

allamasln
Copy link
Contributor

@allamasln allamasln commented Sep 25, 2023

Hello again,

I'm following up on the previous PR #42, and I made an oversight.

Additionally, I opened this new PR due to the unintentional deletion of my original repository. I apologize for any inconvenience.

I have now properly corrected the issue by updating the 'src' attribute to 'href' in the <link> tag instead of in the <script> tag.

Thank you for your time.

@ahmedelgabri ahmedelgabri merged commit 333ffb9 into ahmedelgabri:main Sep 30, 2023
2 checks passed
@ahmedelgabri
Copy link
Owner

ahmedelgabri commented Sep 30, 2023

@allamasln I think we should mark the previous version as deprecated then, to avoid people from using it, what do you think?

@ahmedelgabri
Copy link
Owner

Ok, I unpublished the 8.0.1 and released 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants