Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step 5: decoding data the easy way #4

Merged
merged 4 commits into from
Aug 16, 2024
Merged

step 5: decoding data the easy way #4

merged 4 commits into from
Aug 16, 2024

Conversation

jchavarri
Copy link
Member

@feihong to follow along, one has to pin melange-json to this PR:

opam pin add melange-json https://github.com/melange-community/melange-json/archive/4afc0bce3a2554eb1b6821e6783465bd673a33be.tar.gz

feihong
feihong approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@feihong feihong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

What are we planning to do about this warning?

Warning: Each child in a list should have a unique "key" prop.

one has to pin melange-json

Are we going to make a new release of melange-json later this month?

README.md

```dune
(preprocess
(pps melange.ppx melange-json.ppx reason-react-ppx))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason to add melange-json.ppx in the middle instead of at the end?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetic order.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jchavarri
Copy link
Member Author

What are we planning to do about this warning?

Warning: Each child in a list should have a unique "key" prop.

It was fixed in reasonml/reason-react#852. I will be releasing a new version of reason-react soon.

Are we going to make a new release of melange-json later this month?

ocaml/opam-repository#26366

@jchavarri jchavarri merged commit f45b140 into main Aug 16, 2024
@jchavarri jchavarri deleted the step5 branch August 16, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feihong feihong feihong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchavarri @feihong