Skip to content

Kodus Test PR - 1773501967584 - #1

Open
malinosqui wants to merge 9 commits into
masterfrom
01-01-refactor_logs_export_logsviewset_from_package___init__.py_in_preparation_for_new_endpoints
Open

malinosqui wants to merge 9 commits into
masterfrom
01-01-refactor_logs_export_logsviewset_from_package___init__.py_in_preparation_for_new_endpoints

Conversation

@malinosqui

@malinosqui malinosqui commented Mar 14, 2026

Copy link
Copy Markdown

Based on the code changes, this pull request implements the following enhancements to the logs viewer:

New Features:

  • Log Details Modal: Added a new slide-out modal for viewing complete log details, including timestamp, severity level, and a JSON viewer with an option to recursively parse all string fields as JSON. The modal opens when clicking the "View log details" button or when navigating to a log via a direct link.
  • Floating Action Buttons (FAB): Replaced the static actions column with a floating action button group that appears on hover over each log row. This includes actions for viewing details, prettifying JSON, pinning/unpinning logs, copying the log message, and copying a direct link to the log.

UI/UX Improvements:

  • Streamlined Layout: Removed the fixed-width actions column from the log table header, allowing more space for log content. The action buttons now overlay the message area on hover.
  • Enhanced Message Cell: Updated the message cell layout to accommodate the new floating action buttons with proper padding and scrolling behavior.
  • Scroll Controls: Moved horizontal scroll controls for long log messages into the floating action button group for better accessibility.

Backend Refactoring:

  • Package Structure: Refactored the logs backend API import structure to export LogsViewSet at the package level (products.logs.backend instead of products.logs.backend.api), preparing for future endpoint additions.

Data Handling:

  • Original Log Preservation: Modified the log parsing logic to preserve the original log data structure while maintaining stringified attributes for display purposes, enabling the details modal to show unmodified source data.

Technical Changes:

  • Separated cell scrolling logic into distinct hooks for reference management (useCellScrollRef) and scroll controls (useCellScrollControls) to support the new FAB architecture.
  • Added originalLog field to the ParsedLogMessage type to retain raw log data for detailed inspection.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@malinosqui

Copy link
Copy Markdown
Author

PR Summary (Comment created by Kody 🤖)

Code Review Started! 🚀

✋ Hi, team! I'm already looking at the changed files and starting the review to ensure everything is in order. If you need more details, I'm here! Kody

📂 Changed Files
File Status ➕ Additions ➖ Deletions 🔄 Changes
posthog/api/init.py modified 1 1 2
products/logs/backend/init.py modified 3 0 3
products/logs/frontend/components/LogsViewer/LogDetailsModal/LogDetailsModal.tsx added 111 0 111
products/logs/frontend/components/LogsViewer/LogDetailsModal/index.ts added 3 0 3
products/logs/frontend/components/LogsViewer/LogDetailsModal/logDetailsModalLogic.ts added 38 0 38
products/logs/frontend/components/LogsViewer/LogRowFAB/FABGroup.tsx added 11 0 11
products/logs/frontend/components/LogsViewer/LogRowFAB/LogRowFAB.tsx added 149 0 149
products/logs/frontend/components/LogsViewer/LogRowFAB/index.ts added 2 0 2
products/logs/frontend/components/LogsViewer/LogsViewer.tsx modified 3 0 3
products/logs/frontend/components/LogsViewer/logsViewerLogic.ts modified 12 1 13
products/logs/frontend/components/VirtualizedLogsList/LogRow.tsx modified 12 36 48
products/logs/frontend/components/VirtualizedLogsList/LogRowHeader.tsx modified 0 4 4
products/logs/frontend/components/VirtualizedLogsList/cells/MessageCell.tsx modified 8 18 26
products/logs/frontend/components/VirtualizedLogsList/layoutUtils.ts modified 2 2 4
products/logs/frontend/components/VirtualizedLogsList/useCellScroll.ts modified 76 35 111
products/logs/frontend/logsLogic.tsx modified 21 18 39
products/logs/frontend/types.ts modified 5 1 6
📊 Summary of Changes
  • Total Files: 17
  • Total Lines Added: 457
  • Total Lines Removed: 116
  • Total Changes: 573

@malinosqui

malinosqui commented Mar 14, 2026

Copy link
Copy Markdown
Author

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Cross File
Business Logic

Access your configuration settings here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants