Skip to content

Conversation

@lkomali
Copy link
Contributor

@lkomali lkomali commented Oct 28, 2025

Summary by CodeRabbit

  • Documentation
    • Updated the Endpoint Type Support Matrix with two new endpoint types: huggingface_tei_rankings (supported in GenAI-Perf and AIPerf) and cohere_rankings (supported in AIPerf only).

@lkomali lkomali requested a review from ajcasagrande October 28, 2025 19:11
@github-actions
Copy link

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@lkomali/update-docs

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@lkomali/update-docs

@github-actions github-actions bot added the feat label Oct 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Walkthrough

Two new endpoint types (huggingface_tei_rankings and cohere_rankings) were added to the Endpoint Type Support Matrix in the GenAI-Perf feature comparison documentation, indicating their support status across GenAI-Perf and AIPerf platforms.

Changes

Cohort / File(s) Change Summary
Documentation Update
docs/genai-perf-feature-comparison.md
Added two new rows to the Endpoint Type Support Matrix: huggingface_tei_rankings (✅ | ✅) and cohere_rankings (❌ | ✅) to extend the supported endpoint types feature set

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Documentation-only change with simple table row additions
  • No code logic or structural modifications

Poem

🐰 New endpoints hop into place,
Rankings from Hugging Face and Cohere embrace,
The matrix grows wider, the features expand,
A compare-and-contrast that's perfectly planned! ✨

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat: Update GAP AIPerf comparison doc" is clearly related to the changeset, which adds new endpoint type support rows (huggingface_tei_rankings and cohere_rankings) to the GenAI-Perf vs AIPerf comparison documentation. The title accurately identifies the document being modified and the primary action being taken. While the title is somewhat generic and doesn't specify that new endpoint types are being added, it sufficiently communicates the nature of the update and avoids vague terminology like "misc updates" or "stuff."

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa3b98c and 6dbb6dc.

📒 Files selected for processing (1)
  • docs/genai-perf-feature-comparison.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: build (ubuntu-latest, 3.11)
  • GitHub Check: build (macos-latest, 3.12)
  • GitHub Check: build (ubuntu-latest, 3.12)
  • GitHub Check: build (macos-latest, 3.10)
  • GitHub Check: build (ubuntu-latest, 3.10)
  • GitHub Check: build (macos-latest, 3.11)
  • GitHub Check: integration-tests (ubuntu-latest, 3.11)
  • GitHub Check: integration-tests (ubuntu-latest, 3.12)
  • GitHub Check: integration-tests (ubuntu-latest, 3.10)
🔇 Additional comments (1)
docs/genai-perf-feature-comparison.md (1)

43-44: Documentation update looks good.

The two new endpoint types are properly formatted and logically positioned within the Endpoint Type Support Matrix. The rows follow the established table structure with clear descriptions and accurate support status indicators.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lkomali lkomali force-pushed the lkomali/update-docs branch from 6dbb6dc to ed3ee56 Compare October 29, 2025 18:03
@lkomali lkomali merged commit 82422b8 into main Oct 29, 2025
13 checks passed
@lkomali lkomali deleted the lkomali/update-docs branch October 29, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants