-
Notifications
You must be signed in to change notification settings - Fork 177
BUILD: Change default buildtype from debug to release #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michal-shalev
wants to merge
16
commits into
ai-dynamo:main
Choose a base branch
from
michal-shalev:change-default-buildtype-to-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
629d131
BUILD: Change default buildtype from debug to release
michal-shalev 0ca1dc5
Merge branch 'main' into change-default-buildtype-to-release
michal-shalev abf8cd7
PR fixes
michal-shalev 6ef2dea
Merge branch 'main' into change-default-buildtype-to-release
michal-shalev f1a9592
PR fixes 2.0
michal-shalev 9704852
Merge branch 'main' into change-default-buildtype-to-release
ovidiusm f438b37
Fix typo
michal-shalev 3c86c83
Make AWS S3 Tests buildtype debug
michal-shalev 8d853a4
Make AWS Test buildtype debug
michal-shalev 9f3e26a
Make AWS S3 Tests buildtype debug
michal-shalev 008ae6c
Fix build.sh to run with --buildtype=debug
michal-shalev f787af0
Merge branch 'main' into change-default-buildtype-to-release
michal-shalev 8d73df8
Make Docker build type configurable via BUILD_TYPE arg
michal-shalev a1c3126
Fix Docker build to pass BUILD_TYPE parameter
michal-shalev 14ac5d5
Merge branch 'main' into change-default-buildtype-to-release
michal-shalev f7f99e6
Fix Dockerfile.manylinux as well
michal-shalev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,5 +50,5 @@ NIXL bench also has the option to specify the DOCA GPUNetIO backend. An example | |
|
|
||
| ## Caveats | ||
|
|
||
| By default NIXL is built with `buildtype=debug` option. This is ok for correctness and debugging. | ||
| To run for performace (e.g. with NIXL bench) t's hightly recommended to build NIXL with `buildtype=release`. | ||
| By default NIXL is built with `buildtype=release` option for optimal performance. | ||
|
||
| For debugging purposes, NIXL can be built with `buildtype=debug`. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.