libfabric: fix asymmetrical rails for heterogeneous node types. #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi fengjica! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
fengjica
force-pushed
the
dev/rails_mismatch
branch
2 times, most recently
from
f3b6431 to
072697c
Compare
yexiang-aws
reviewed
Oct 15, 2025
yexiang-aws
approved these changes
Oct 16, 2025
|
/build |
|
/ok to test 807bbbe |
|
/build |
fengjica
force-pushed
the
dev/rails_mismatch
branch
from
807bbbe to
bf553aa
Compare
This change: - passes the number of rail endpoints to others via serialization, - added all remote endpoints for each local rails into addresses, - round-robin pick local rails and remote endpoints for data transfer. Signed-off-by: Feng Ji <[email protected]>
fengjica
force-pushed
the
dev/rails_mismatch
branch
from
bf553aa to
99d2627
Compare
|
/build |
|
/ok to test 99d2627 |
|
/build |
|
/ok to test e656843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
What?
Fix the assumption in the code today that rails configuration is the same across nodes.
Why?
Users intend to use AWS p5en and p6 nodes together.
How?
See changes described above.