Merge #221
Merged
Merge #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain-ai#25771) Ignore specific integration tests that handles specific tool calling cases that will soon be fixed.
Thank you for contributing to LangChain!
- [x] **PR title**: "langchain: Chains: query_constructor: add date time
parser"
- [x] **PR message**:
- **Description:** add date time parser to langchain Chains
query_constructor
- **Issue: langchain-ai#25526
- [ ] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [ ] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
) Closes langchain-ai#25784 See additional discussion [here](langchain-ai@0a4ee86#r145147380).
Co-authored-by: Bagatur <[email protected]>
…langchain-ai#25728) **Description:** Make the hyperlink only appear once in the extract_hyperlinks tool output. (for some websites output contains meaningless '#' hyperlinks multiple times which will extend the tokens of context window without any advantage) **Issue:** None **Dependencies:** None
…in-ai#25727) ### Description adds an init method to ChatDeepInfra to set the model_name attribute accordings to the argument ### Issue currently, the model_name specified by the user during initialization of the ChatDeepInfra class is never set. Therefore, it always chooses the default model (meta-llama/Llama-2-70b-chat-hf, however probably since this is deprecated it always uses meta-llama/Llama-3-70b-Instruct). We stumbled across this issue and fixed it as proposed in this pull request. Feel free to change the fix according to your coding guidelines and style, this is just a proposal and we want to draw attention to this problem. ### Dependencies no additional dependencies required Feel free to contact me or @timo282 and @finitearth if you have any questions. --------- Co-authored-by: Bagatur <[email protected]> Co-authored-by: Bagatur <[email protected]>
…ever` (langchain-ai#25803) - Complete missing args in api doc
…5781) **Description:** Adds the 'score' returned by Pinecone to the `PineconeHybridSearchRetriever` list of returned Documents. There is currently no way to return the score when using Pinecone hybrid search, so in this PR I include it by default. --------- Co-authored-by: Chester Curme <[email protected]>
Add array data type for milvus vector store collection create
Thank you for contributing to LangChain!
- [x] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core,
experimental, etc. is being modified. Use "docs: ..." for purely docs
changes, "templates: ..." for template changes, "infra: ..." for CI
changes.
- Example: "community: add foobar LLM"
- [x] **PR message**: ***Delete this entire checklist*** and replace
with
- **Description:** a description of the change
- **Issue:** the issue # it fixes, if applicable
- **Dependencies:** any dependencies required for this change
- **Twitter handle:** if your PR gets announced, and you'd like a
mention, we'll gladly shout you out!
- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
---------
Signed-off-by: ChengZi <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: ChengZi <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
I have validated langchain interface with tei/tgi works as expected when TEI and TGI running on Intel Gaudi2. Adding some references to notebooks to help users find relevant info. --------- Co-authored-by: Rita Brugarolas <[email protected]> Co-authored-by: Chester Curme <[email protected]>
…hain-ai#25828) Commandeering langchain-ai#23243 as maintainers don't have ability to modify that PR. Fixes langchain-ai#22827 --------- Co-authored-by: Ming Quah <[email protected]>
…ai#25777) ## Description In `langchain_prompty`, messages are templated by Prompty. However, a call to `ChatPromptTemplate` was initiating a second templating. We now convert parsed messages to `Message` objects before calling `ChatPromptTemplate`, signifying clearly that they are already templated. We also revert langchain-ai#25739 , which applied to this second templating, which we now avoid, and did not fix the original issue. ## Issue Closes langchain-ai#25703
…notebook (langchain-ai#25824) Thank you for contributing to LangChain! - [ ] **PR title**: docs: fixed syntax error in ChatAnthropic Example - rag app tutorial notebook - generation - [ ] **PR message**: - **Description:** Fixed a syntax error in the ChatAnthropic initialization example in the RAG tutorial notebook. The original code had an extra set of quotation marks around the model parameter, which would cause a Python syntax error. The corrected version removes these unnecessary quotes. - **Dependencies:** No new dependencies required for this documentation fix. I've verified that the corrected code is syntactically valid and matches the expected format for initializing a ChatAnthropic instance in LangChain. - **Twitter handle:** madhu_shantan - [ ] **Add tests and docs**: the error in Jupyter notebook: <img width="1189" alt="Screenshot 2024-08-29 at 12 43 47 AM" src="https://github.com/user-attachments/assets/07148a93-300f-40e2-ad4a-ac219cbb56a4"> the corrected cell: <img width="983" alt="Screenshot 2024-08-29 at 12 44 18 AM" src="https://github.com/user-attachments/assets/75b1455a-3671-454e-ac16-8ca77c049dbd"> - [ ] **Lint and test**: As this is a documentation-only change, I have not run the full test suite. However, I have verified that the corrected code example is syntactically valid and matches the expected usage of the ChatAnthropic class. the error in the docs is here - <img width="1020" alt="Screenshot 2024-08-29 at 12 48 36 AM" src="https://github.com/user-attachments/assets/812ccb20-b411-4a5b-afc1-41742efb32a7">
fix some integration test issues: https://github.com/langchain-ai/langchain/actions/runs/10688447230/job/29628412258 Signed-off-by: ChengZi <[email protected]> Co-authored-by: Erick Friis <[email protected]>
Added missed provider pages and links. Fixed inconsistent formatting.
initalize -> initialize Co-authored-by: Erick Friis <[email protected]>
Added missed provider pages and links. Fixed inconsistent formatting. Co-authored-by: Erick Friis <[email protected]>
) Small improvement on ChatOllama description --------- Co-authored-by: Marcelo Machado <[email protected]> Co-authored-by: Erick Friis <[email protected]>
…ai#26105) Users are having version conflicts with `unstructured-client` as described here: https://unstructuredw-kbe4326.slack.com/archives/C06JJHC9G4U/p1725557970546199?thread_ts=1725035247.162819&cid=C06JJHC9G4U This PR fixes that issue and should update the version to "0.1.3" as well for a clean-slate version for users to install Co-authored-by: Erick Friis <[email protected]>
This PR fixes a minor typo in the ScrapflyLoader documentation. The word "passigng" was changed to "passing." Before: passigng After: passing This change improves the clarity and professionalism of the documentation. Co-authored-by: Ashar <[email protected]>
The object extends from langchain_community.chat_models.openai.ChatOpenAI which doesn't have `bind_tools` defined. I tried extending from `langchain_openai.ChatOpenAI` in langchain-ai#25975 but that PR got closed because this is not correct. So adding our own `bind_tools` (which for now copying from ChatOpenAI is good enough) will solve the tool calling issue we are having now. --------- Co-authored-by: Erick Friis <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
Changed > "At a high-level, the steps of constructing a knowledge are from text are:" to > "At a high-level, the steps of constructing a knowledge graph from text are:" Co-authored-by: Erick Friis <[email protected]>
Thank you for contributing to LangChain!
- [x] **PR title**: "package: description"
- Where "package" is whichever of langchain, community, core,
experimental, etc. is being modified. Use "docs: ..." for purely docs
changes, "templates: ..." for template changes, "infra: ..." for CI
changes.
- Example: "community: add foobar LLM"
- [x] **PR message**: ***Delete this entire checklist*** and replace
with
- **Description:** Fix docstring for two functions that look like have
docstrings carried over from other functions.
- **Issue:** Not found issue reporting the miss-leading docstrings.
- **Dependencies:** None
- **Twitter handle:**
- [x] **Add tests and docs**: If you're adding a new integration, please
include
1. a test for the integration, preferably unit tests that do not rely on
network access,
2. an example notebook showing its use. It lives in
`docs/docs/integrations` directory.
- [x] **Lint and test**: Run `make format`, `make lint` and `make test`
from the root of the package(s) you've modified. See contribution
guidelines for more: https://python.langchain.com/docs/contributing/
Additional guidelines:
- Make sure optional dependencies are imported within a function.
- Please do not add dependencies to pyproject.toml files (even optional
ones) unless they are required for unit tests.
- Most PRs should not touch more than one package.
- Changes should be backwards compatible.
- If you are adding something to community, do not re-import it in
langchain.
If no one reviews your PR within a few days, please @-mention one of
baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
---------
Co-authored-by: Erick Friis <[email protected]>
…e introduce in langchain-google-community 1.0.9 (langchain-ai#26184) Hello, fix: langchain-ai#26183 Adding documentation regarding SQL like filter for Google BigQuery Vector Search coming in next langchain-google-community 1.0.9 release. Note: langchain-google-community==1.0.9 is not yet released Question: There is no way to warn the user int the doc about the availability of a feature after a specific package version ? --------- Co-authored-by: Erick Friis <[email protected]>
Add tool calling example to AI21 docs
…n-ai#26235) This fixes the issue where `__start__` and `__end__` node labels are being interpreted as markdown, as of the most recent Mermaid update
Co-authored-by: Erick Friis <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" docs:tutorials:llm_chain:fix typo - [ ] **PR message**: fix typo in llm chain tutorial - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17. Co-authored-by: Erick Friis <[email protected]>
While going through the chatbot tutorial, I noticed a couple of typos and grammatical issues. Also, the pip install command for langchain_community was commented out, but the document mentions installing it. --------- Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Спасибо за помощь в развитии GigaChain!
При создании PR придерживайтесь простых правил: