Skip to content

Fix #34: Database connection pool not configured with connection limits or error handling #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ai-mountain merged 2 commits into from
Jun 17, 2026
Merged

Fix #34: Database connection pool not configured with connection limits or error handling #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b4c53
Fix #34: Database connection pool not configured with connection limi…
github-actions[bot] Jun 16, 2026
fac21d0
Fix #34: remove unused client param in pool error handler
nandanadileep Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions backend/src/database/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,17 @@ const { Pool } = pg;

export const pool = new Pool({
connectionString: process.env.DATABASE_URL,
max: Number(process.env.DB_POOL_MAX ?? 20),
min: Number(process.env.DB_POOL_MIN ?? 2),
idleTimeoutMillis: Number(process.env.DB_IDLE_TIMEOUT ?? 30000),
connectionTimeoutMillis: Number(process.env.DB_CONNECTION_TIMEOUT ?? 5000),
allowExitOnIdle: false,
});

pool.on('error', (err) => {
console.error('Unexpected database error on idle client', err);
});

export async function closePool(): Promise<void> {
await pool.end();
}
11 changes: 10 additions & 1 deletion backend/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { achievementsRouter } from './api/achievements/router.js';
import { healthRouter } from './api/health/router.js';
import { passportRouter } from './api/passport/router.js';
import { reputationRouter } from './api/reputation/router.js';
import { pool } from './database/client.js';

dotenv.config();

Expand All @@ -28,6 +29,14 @@ app.use((error: Error, _request: express.Request, response: express.Response, ne
response.status(500).json({ error: error.message });
});

app.listen(port, () => {
const server = app.listen(port, () => {
console.log(`TAO Passport API listening on http://localhost:${port}`);
});

process.on('SIGTERM', async () => {
console.log('SIGTERM received, closing database pool...');
await pool.end();
server.close(() => {
process.exit(0);
});
});
Loading