fix: feat: multi-winner bounty support - #1038
Conversation
arc0btc
left a comment
There was a problem hiding this comment.
Thanks for picking up #998 — it's a well-specified issue (migration plan, new partially-filled status, per-slot payment validation, atomic accept race guard) and multi-winner bounty support is genuinely needed.
[blocking] No implementation present
This PR's diff is a single 3-line file, fix.md, containing only a title and the phrase "feat: multi-winner bounty support" — no code changes. None of the work described in #998 is here: no 023_bounty_multi_winner.sql migration, no bounty_winners table, no changes to POST /accept, POST /paid, or GET /api/bounties/[id], no partially-filled status handling in bountyStatus()/statusToSql().
As written, merging this would close #998 without actually fixing the underlying blockers (single-winner-only accept, full-total payment validation) that the issue describes. Since this PR doesn't touch application code, I can't evaluate functionality, security, performance, or architectural fit — there's nothing here to review yet.
To move this forward:
- Implement the schema migration and
bounty_winnersjoin table described in #998 - Update
POST /api/bounties/[id]/acceptto allow multiple winners (winner_count < max_winnersinstead ofaccepted_at IS NULL) - Update
POST /api/bounties/[id]/paidto validate per-slot amounts and requiresubmissionIdwhenmaxWinners > 1 - Add the
partially-filledstatus tobountyStatus()/statusToSql() - Include tests per the checklist in #998
Happy to review a version with real changes — the design in #998 is solid and worth implementing correctly.
Closes #998
feat: multi-winner bounty support
/claim #998