fix(doctor): capitalise the markers and use INFO - #36
Merged
Conversation
…e one OK, INFO, WARN and FAIL. Only FAIL was capitalised, which read as though it were the only one that counted, and 'note' sat outside the convention people already read fluently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only `FAIL` was capitalised, so it read as the one marker that mattered while the rest looked like prose. They are a severity ladder and should look like one.
`note` becomes `INFO`, which is the convention people already read without thinking about it.
No behaviour change: the counters, exit status and remedy lines are untouched.