fix: read the tag annotation checkout has not yet clobbered - #64
Merged
Conversation
actions/checkout fetches the annotated tag and then force-updates refs/tags/<tag> to the commit it checks out, leaving a lightweight tag. Both jobs that read the annotation read it after that, so verify refused every tag and the release notes would have been the commit message. The second is the failure that matters. Refusing a lightweight tag exists precisely because for-each-ref falls through to the commit message on one, and the guard was defeated by the same mechanism it guards against. Only the loud failure stopped it publishing. Both jobs now fetch the tag ref back before trusting it. fetch-depth: 0 does not help, because checkout's second fetch runs regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
actions/checkoutforce-updatesrefs/tags/<tag>to the commit after fetching the real tag, so both jobs that read the annotation were reading a lightweight tag.verifyrefusedv0.10.4on its first real use. The quieter half is thatreleasewould have publishedfeat: cut a release by pushing an annotated tag (#62)as the notes — the guard against exactly that was defeated by the same mechanism.Fix is a re-fetch of the tag ref in both jobs. Reproduced and verified against a clean clone:
commitafter simulating checkout's second fetch,tagwith the right annotation after the re-fetch.