fix: repair a moved runner's links when re-registering it - #75
Merged
Conversation
reregister is the documented recovery from a rename that failed part way, and that failure leaves the runner directories moved with their bin and externals links still pointing where they used to be. config.sh cannot start against those, so the recovery command hit the same wall as the thing it was recovering from. A no-op on a healthy runner, whose links are already relative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73.
reregisteris the documented recovery from arenamethat failed part way, and that failure leaves the runner directories moved with theirbinandexternalslinks still pointing where they used to be.config.shcannot start against those, so the recovery command hit the same wall as the thing it was recovering from.Repairing the links is part of repairing the install rather than a separate errand, and it is a no-op on a healthy runner whose links are already relative.
Covered by a case that moves an install behind the tool's back and asserts
reregisterboth succeeds and leaves the link relative.