-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyedit (grammar, spelling, etc.) for clarity #568
base: master
Are you sure you want to change the base?
Conversation
- Small grammar, spelling, and punctuation fixes - A few language shifts or additions to further clarity. - Refactored to have one-line per sentence for easier reading/reviewing of diffs.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @quaid. Thanks for your PR. I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Although you may see it spelled with and without spaces, looking at the ODH website it's pretty clear the proper way is "Open Data Hub". This is important whenever it's a proper name, and more important if it's someone's trademarks. Also, consistency and accuracy help create reader comfort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks your PR @quaid! 😄
Suggested couple some other minor grammatical changes that I noticed.
|
||
You do not need to be familiar with these any of tools being used in this workshop, and you should have around an intermediate level of comfort with technology and learning new technical concepts. | ||
You do not need to be familiar with the any of tools being used in this workshop, and you should have around an intermediate level of comfort with technology and learning new technical concepts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to be familiar with the any of tools being used in this workshop, and you should have around an intermediate level of comfort with technology and learning new technical concepts. | |
You do not need to be familiar with any of the tools being used in this workshop, and you should have around an intermediate level of comfort with technology and learning new technical concepts. |
|
||
3. **Familiarity with Python** - The AIOps tools has been built using the Python programming language. Familiarity with Python is preferred but not compulsory. One can still complete the workshop without prior Python knowledge. | ||
3. **Familiarity with Python** - The AIOps tools has been built using the Python programming language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. **Familiarity with Python** - The AIOps tools has been built using the Python programming language. | |
3. **Familiarity with Python** - The AIOps tools have been built using the Python programming language. |
Related Issues and Dependencies
N/A
This introduces a breaking change
This Pull Request implements
Small grammar, spelling, and language choice fixes as part of a copyedit.
Description