Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update precommit hooks #33

Merged

Conversation

chauhankaranraj
Copy link
Member

Related Issues and Dependencies

None

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

The precommit hooks are quite outdated on this repo. This might be causing some CI check failures such as this one. This PR updates precommit hooks to latest versions.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2022
@sesheta
Copy link
Contributor

sesheta commented Jan 10, 2022

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[ERROR] The hook `mypy` requires pre-commit version 2.9.2 but version 2.4.0 is installed.  Perhaps run `pip install --upgrade pre-commit`.

1 similar comment
@sesheta
Copy link
Contributor

sesheta commented Jan 10, 2022

Pre-Commit Test failed! Click here
[INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[ERROR] The hook `mypy` requires pre-commit version 2.9.2 but version 2.4.0 is installed.  Perhaps run `pip install --upgrade pre-commit`.

Copy link
Contributor

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Contributor

sesheta commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please ask for approval from chauhankaranraj after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chauhankaranraj chauhankaranraj merged commit 1687323 into aicoe-aiops:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants