-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/xx/increase timeout of di test #529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 79.92% 79.92%
=======================================
Files 27 27
Lines 3815 3815
=======================================
Hits 3049 3049
Misses 766 766
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f8dfd1e
to
e4efda1
Compare
Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ? |
Looking at the screenshots they are still loading. Strange, maybe the github runners are slow today? I wonder if we could speed the loading somehow, perhaps by making the notebook simpler or split it up into multiple notebooks if possible? For now I'd try to increase the wait that wait for the busy icon to disappear even further, from 120s to 240s or something like that? |
Okay, thanks. I give it a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it worked! Let's see if this improves the test flakiness.
Nice! |
The smoke test in #511 failed but because of structure notebooks. From the screenshots the notebook is still loading. I guess the
timeout=10
is too short?