Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/xx/increase timeout of di test #529

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 20, 2023

The smoke test in #511 failed but because of structure notebooks. From the screenshots the notebook is still loading. I guess the timeout=10 is too short?

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebc7120) 79.92% compared to head (18496a2) 79.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   79.92%   79.92%           
=======================================
  Files          27       27           
  Lines        3815     3815           
=======================================
  Hits         3049     3049           
  Misses        766      766           
Flag Coverage Δ
python-3.10 79.92% <ø> (ø)
python-3.8 79.95% <ø> (ø)
python-3.9 79.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the fix/xx/increase-timeout-of-di-test branch from f8dfd1e to e4efda1 Compare October 20, 2023 11:48
@unkcpz
Copy link
Member Author

unkcpz commented Oct 20, 2023

Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?

@danielhollas
Copy link
Contributor

Not sure what happened, but the notebook for the structure test all fail, any idea? @danielhollas @yakutovicha ?

Looking at the screenshots they are still loading. Strange, maybe the github runners are slow today? I wonder if we could speed the loading somehow, perhaps by making the notebook simpler or split it up into multiple notebooks if possible?

For now I'd try to increase the wait that wait for the busy icon to disappear even further, from 120s to 240s or something like that?

tests_notebooks/conftest.py Outdated Show resolved Hide resolved
@unkcpz
Copy link
Member Author

unkcpz commented Oct 20, 2023

from 120s to 240s or something like that?

Okay, thanks. I give it a try.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked! Let's see if this improves the test flakiness.

@unkcpz unkcpz merged commit 5b303df into master Oct 20, 2023
@unkcpz unkcpz deleted the fix/xx/increase-timeout-of-di-test branch October 20, 2023 13:08
@unkcpz
Copy link
Member Author

unkcpz commented Oct 20, 2023

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants