Allow set key_filename/key_policy in computer configure #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
commented
Nov 10, 2023
Comment on lines
886
to
898
| if "proxy_jump" in self.computer_configure: | ||
| authparams["proxy_jump"] = self.computer_configure["proxy_jump"] | ||
|
|
||
| if "proxy_command" in self.computer_configure: | ||
| authparams["proxy_command"] = self.computer_configure["proxy_command"] | ||
|
|
||
| if "key_filename" in self.computer_configure: | ||
| authparams["key_filename"] = self.computer_configure["key_filename"] | ||
|
|
||
| if "key_policy" in self.computer_configure: | ||
| authparams["key_policy"] = self.computer_configure["key_policy"] |
There was a problem hiding this comment.
Such if clauses can be simplified and moved to the authparams, but since there are still three sources for the setup, maybe good to keep it as it is?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 85.83% 85.88% +0.04%
==========================================
Files 27 27
Lines 4610 4618 +8
==========================================
+ Hits 3957 3966 +9
+ Misses 653 652 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
unkcpz
force-pushed
the
fix/xx/key-policy-filename-configure
branch
from
937241a to
7bb157c
Compare
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
unkcpz
force-pushed
the
fix/xx/key-policy-filename-configure
branch
from
7bb157c to
6f8ea9f
Compare
yakutovicha
requested changes
Nov 15, 2023
unkcpz
force-pushed
the
fix/xx/key-policy-filename-configure
branch
from
6076b23 to
6d549b6
Compare
unkcpz
added a commit
to unkcpz/aiidalab-widgets-base
that referenced
this pull request
Nov 16, 2023
…#537) This PR detects the unsaved changes in the already confirmed steps. If there are any unsaved changes, it will block the submit step and show the blocker messages there. This is achieved by observing the selected_index of the _wizard_app_widget, and comparing the related values. --------- Co-authored-by: Jusong Yu <[email protected]> Co-authored-by: Miki Bonacci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some values for authinfo setting that are hardcoded. It should be able to be set from computer-configure dict. This is required by the CSCS MFA configure setup. The key filename is set in configure to
cscs-keybut not passed to theAuthInfo.