Adding support for orm.Containerized codes#617
Merged
unkcpz merged 4 commits intoaiidalab:masterfrom Jul 5, 2024
Merged
Conversation
This is obtained using the AiidaCodeSetup().code_setup attribute. I am not sure is the right way, as we should also provide the possibility to change the `image_name` and the `engine_command` via the GUI.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 83.65% 83.62% -0.03%
==========================================
Files 16 16
Lines 3511 3517 +6
==========================================
+ Hits 2937 2941 +4
- Misses 574 576 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
unkcpz
requested changes
Jul 5, 2024
Member
unkcpz
left a comment
unkcpz
left a comment
There was a problem hiding this comment.
Thanks @mikibonacci, some minor requests.
codes -> code Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
…esources.py Using orm.AbstractCode instead of (orm.InstalledCode, orm.ContainerizedCode), so we automatically provide support for all the Code classes Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
there was still one `codes` left behind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is obtained using the AiidaCodeSetup().code_setup attribute.
I am not sure is the better way, as we should also provide the possibility to change the
image_nameand theengine_commandvia the GUI. However, I think that for now this is acceptable, as the containerized codes are mainlyset up by using the information on the
aiida-resource-registryrepo. Actually, it is a really new thing and for now only thephonopy@merlin-cpuis defined.