Fix notebook tests #630
Merged
Fix notebook tests #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 16 16
Lines 3522 3522
=======================================
Hits 2945 2945
Misses 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
danielhollas
commented
Aug 23, 2024
Comment on lines
+49
to
+51
| pytest-docker~=3.1.0 | ||
| pytest-selenium~=4.1.0 | ||
| pytest-timeout~=2.3.0 |
There was a problem hiding this comment.
To be on the safe side and to reduce potential churn, let's pin all test dependencies to minor versions.
|
@edan-bainglass please take a look. Ideally we merge this first so other PRs can have tests passing. |
|
Going to land this now as I will be AFK for the next two hours. |
edan-bainglass
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last successfully run of notebook tests is from July 8. There were no code changes that should impact the tests, we need to investigate what changed since then.
EDIT: It looks like just increasing the wait time tolerance fixes the issue. Perhaps the github runners just got slower? Not sure.