-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to hide the header of the Wizard App #638
Allow user to hide the header of the Wizard App #638
Conversation
this test is failing , tests/test_databases.py::test_cod_query_widget |
The failed test is related to the query of the Crystallography Open Database, Maybe some internet problem of the database. thus it is not related to this PR. |
Should the timeout be increased ? at least to 60 sec ? |
It seems the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@superstar54 could you open an issue to remove http requests in our test suite? I think we should mock them somehow so that we don't run into these transient issues. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #638 +/- ##
=======================================
Coverage 83.49% 83.50%
=======================================
Files 17 17
Lines 3539 3546 +7
=======================================
+ Hits 2955 2961 +6
- Misses 584 585 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @danielhollas , the HTTP request is inside an AiiDA function. Do we really need to test it here? |
I don't know, probably not, as long as we test the widget functionality in some way. |
We plan to remove the header in the QE App, as suggested by @giovannipizzi and @cpignedoli in aiidalab/aiidalab-qe#813.
This PR allows the user to hide the header of the Wizard App.