Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to hide the header of the Wizard App #638

Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Oct 8, 2024

We plan to remove the header in the QE App, as suggested by @giovannipizzi and @cpignedoli in aiidalab/aiidalab-qe#813.

This PR allows the user to hide the header of the Wizard App.

@AndresOrtegaGuerrero
Copy link
Member

this test is failing , tests/test_databases.py::test_cod_query_widget

@superstar54
Copy link
Member Author

this test is failing , tests/test_databases.py::test_cod_query_widget

The failed test is related to the query of the Crystallography Open Database, Maybe some internet problem of the database. thus it is not related to this PR.

@AndresOrtegaGuerrero
Copy link
Member

Should the timeout be increased ? at least to 60 sec ?

@superstar54
Copy link
Member Author

superstar54 commented Oct 8, 2024

It seems the timeout is not a problem, but the cod service is not reachable for the moment. http://www.crystallography.net/

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielhollas
Copy link
Contributor

It seems the timeout is not a problem, but the cod service is not reachable for the moment. http://www.crystallography.net/

@superstar54 could you open an issue to remove http requests in our test suite? I think we should mock them somehow so that we don't run into these transient issues.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.50%. Comparing base (c697d27) to head (40e7916).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
aiidalab_widgets_base/wizard.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   83.49%   83.50%           
=======================================
  Files          17       17           
  Lines        3539     3546    +7     
=======================================
+ Hits         2955     2961    +6     
- Misses        584      585    +1     
Flag Coverage Δ
python-3.11 83.50% <90.00%> (+<0.01%) ⬆️
python-3.9 83.54% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 152c2bb into aiidalab:master Oct 21, 2024
11 checks passed
@superstar54 superstar54 deleted the feature/allow_hide_wizard_header branch October 21, 2024 16:15
@superstar54
Copy link
Member Author

Hi @danielhollas , the HTTP request is inside an AiiDA function. Do we really need to test it here?

@danielhollas
Copy link
Contributor

Hi @danielhollas , the HTTP request is inside an AiiDA function. Do we really need to test it here?

I don't know, probably not, as long as we test the widget functionality in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants