Pydantic version caused mypy error

aiidateam · Nov 22, 2024 · 0dabade · 0dabade
1 parent f415f55
commit 0dabade
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/aiida/common/pydantic.py b/src/aiida/common/pydantic.py
@@ -14,7 +14,7 @@ def MetadataField(  # noqa: N802
     short_name: str | None = None,
     option_cls: t.Any | None = None,
     **kwargs,
-):
+) -> t.Any | None:
     """Return a :class:`pydantic.fields.Field` instance with additional metadata.
 
     .. code-block:: python
@@ -41,7 +41,7 @@ class Model(BaseModel):
     field_info = Field(default, **kwargs)
 
     for key, value in (('priority', priority), ('short_name', short_name), ('option_cls', option_cls)):
-        if value is not None:
+        if value is not None and field_info is not None:
             field_info.metadata.append({key: value})
 
     return field_info
diff --git a/tests/cmdline/groups/test_dynamic.py b/tests/cmdline/groups/test_dynamic.py
@@ -17,7 +17,7 @@ class Model(BaseModel):
         union_type: t.Union[int, float] = Field(title='Union type')
         without_default: str = Field(title='Without default')
         with_default: str = Field(title='With default', default='default')
-        with_default_factory: str = Field(title='With default factory', default_factory=lambda: True)
+        with_default_factory: str = Field(title='With default factory', default_factory=lambda: True)  # type: ignore[assignment]
 
 
 def test_list_options(entry_points):